graceguo-supercat commented on a change in pull request #9311: [cache warm_up]
warm_up slice with dashboard default_filters
URL:
https://github.com/apache/incubator-superset/pull/9311#discussion_r393258452
##########
File path: superset/views/utils.py
##########
@@ -262,3 +263,89 @@ def get_time_range_endpoints(
return (TimeRangeEndpoint(start), TimeRangeEndpoint(end))
return (TimeRangeEndpoint.INCLUSIVE, TimeRangeEndpoint.EXCLUSIVE)
+
+
+CONTAINER_TYPES = ["COLUMN", "GRID", "TABS", "TAB", "ROW"]
+
+
+def get_dashboard_extra_filters(
Review comment:
Celery task is here:
https://github.com/apache/incubator-superset/blob/000a038af193f2770dfe23a053bd1ff5e9e72bd4/superset/tasks/cache.py#L39
It missed a logic to check default_filters's scope if the scope is not
globally, but pretty close. So my plan is to add logic for warm_up endpoint,
then update Celery task accordingly in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
