graceguo-supercat commented on a change in pull request #9311: [cache warm_up] 
warm_up slice with dashboard default_filters
URL: 
https://github.com/apache/incubator-superset/pull/9311#discussion_r393266748
 
 

 ##########
 File path: superset/views/utils.py
 ##########
 @@ -262,3 +263,89 @@ def get_time_range_endpoints(
         return (TimeRangeEndpoint(start), TimeRangeEndpoint(end))
 
     return (TimeRangeEndpoint.INCLUSIVE, TimeRangeEndpoint.EXCLUSIVE)
+
+
+CONTAINER_TYPES = ["COLUMN", "GRID", "TABS", "TAB", "ROW"]
+
+
+def get_dashboard_extra_filters(
 
 Review comment:
   oh never mind, the Celery warmup change is very simple. So i just commit 
Celery warmup changes here. And all unit tests can be re-used without any 
change!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to