graceguo-supercat edited a comment on issue #9311: [cache warm_up] warm_up slice with dashboard default_filters URL: https://github.com/apache/incubator-superset/pull/9311#issuecomment-600316344 > looking good so far! > > after looking through this and not knowing potential values for the filter object, i'm wondering if most of the `.get("value", {})` and `.get("value", [])` statements should be `.get("value") or {}` and `.get("value") or []` @etr2460 Thanks for code review! I follow documentation here: https://docs.python.org/2/library/stdtypes.html#dict.get and https://stackoverflow.com/questions/33263623/dict-getkey-default-vs-dict-getkey-or-default I would say most of my usage is for the dict that doesn't have key. Why do you think they should be `.get("value") or {}` and `.get("value") or []`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
