graceguo-supercat edited a comment on issue #9311: [cache warm_up] warm_up slice with dashboard default_filters URL: https://github.com/apache/incubator-superset/pull/9311#issuecomment-600327324 > What i'm saying is if you default it to `[]` with or then you don't even need to check if it's falsey. The empty array will simply bypass the for loop My question is this comment: `after looking through this and not knowing potential values for the filter object, i'm wondering if most of the .get("value", {}) and .get("value", []) statements should be .get("value") or {} and .get("value") or []` Why should change most of `dict.get(key, default_value)` to `dict.get(key) or default_value`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
