etr2460 commented on issue #9311: [cache warm_up] warm_up slice with dashboard default_filters URL: https://github.com/apache/incubator-superset/pull/9311#issuecomment-600329765 Here's a specific example: You have `filter_scopes = json_metadata.get("filter_scopes", {})` in the code, and then you later assume `filter_scopes` is a Dict. However, because the json_metadata can be edited by the user, it could be `None` or `False`. This would break with your current code, but not with `json_metadata.get("filter_scopes") or {}` In general, I think we need to be a lot more defensive with parsing the json_metadata blob here, because an invalid metadata field isn't validated on save and it would break the code here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
