etr2460 commented on a change in pull request #9338: [SQLLAB] add checkbox to
control autocomplete
URL:
https://github.com/apache/incubator-superset/pull/9338#discussion_r396197158
##########
File path: superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx
##########
@@ -34,41 +33,44 @@ import {
const langTools = ace.acequire('ace/ext/language_tools');
-const propTypes = {
- actions: PropTypes.object.isRequired,
- onBlur: PropTypes.func,
- sql: PropTypes.string.isRequired,
- schemas: PropTypes.array,
- tables: PropTypes.array,
- functionNames: PropTypes.array,
- extendedTables: PropTypes.array,
- queryEditor: PropTypes.object.isRequired,
- height: PropTypes.string,
- hotkeys: PropTypes.arrayOf(
- PropTypes.shape({
- key: PropTypes.string.isRequired,
- descr: PropTypes.string.isRequired,
- func: PropTypes.func.isRequired,
- }),
- ),
- onChange: PropTypes.func,
+type HotKey = {
+ key: string;
+ descr: string;
+ name: string;
+ func: () => void;
};
-const defaultProps = {
- onBlur: () => {},
- onChange: () => {},
- schemas: [],
- tables: [],
- functionNames: [],
- extendedTables: [],
-};
Review comment:
i think you can set these default props on line 68 in the new file with
something like:
```typescript
constructor({ onBlur = () => {}, onChange = () => {}, ... , ...restProps}:
Props) {
super({onBlur, onChange, ..., ...restProps});
```
then you don't need to add in all the checks like ` if (this.props.onBlur)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
