etr2460 commented on a change in pull request #9338: [SQLLAB] add checkbox to
control autocomplete
URL:
https://github.com/apache/incubator-superset/pull/9338#discussion_r396773704
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -93,6 +94,7 @@ class SqlEditor extends React.PureComponent {
northPercent: props.queryEditor.northPercent || INITIAL_NORTH_PERCENT,
southPercent: props.queryEditor.southPercent || INITIAL_SOUTH_PERCENT,
sql: props.queryEditor.sql,
+ autocompleteEnabled: true,
Review comment:
Not blocking, but i'll bet once we roll this out, people will want the
ability to default this setting or to have it grab the setting from the current
tab when creating the new one.
Food for thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
