dpgaspar commented on a change in pull request #9411: [mypy] Enforcing typing
for superset.charts
URL:
https://github.com/apache/incubator-superset/pull/9411#discussion_r399835630
##########
File path: superset/dao/base.py
##########
@@ -75,7 +75,7 @@ def find_by_ids(cls, model_ids: List[int]) -> List[Model]:
return query.all()
@classmethod
- def create(cls, properties: Dict, commit=True) -> Optional[Model]:
+ def create(cls, properties: Dict, commit=True) -> Model:
Review comment:
A bit redundant but since `check_ownership` also adds `bool` for the named
parameter:
`def create(cls, properties: Dict, commit: bool = True) -> Model:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
