john-bodley commented on a change in pull request #9411: [mypy] Enforcing
typing for superset.charts
URL:
https://github.com/apache/incubator-superset/pull/9411#discussion_r399842193
##########
File path: superset/views/base.py
##########
@@ -392,7 +393,7 @@ def check_ownership(obj, raise_if_false=True):
orig_obj = scoped_session.query(obj.__class__).filter_by(id=obj.id).first()
# Making a list of owners that works across ORM models
- owners = []
+ owners: User = []
Review comment:
BTW the reasons these issues didn't fire is merely because the enforcement
is on the `superset.charts` module. It simply requires the return types for
calls to be defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
