john-bodley commented on a change in pull request #9416: [mypy] Enforcing typing for some modules URL: https://github.com/apache/incubator-superset/pull/9416#discussion_r399854948
########## File path: superset/common/tags.py ########## @@ -14,14 +14,15 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - +from sqlalchemy import Metadata +from sqlalchemy.engine import Engine from sqlalchemy.exc import IntegrityError from sqlalchemy.sql import and_, func, functions, join, literal, select from superset.models.tags import ObjectTypes, TagTypes -def add_types(engine, metadata): +def add_types(engine: Engine, metadata: Metadata) -> None: Review comment: @dpgaspar could you verify if the `metadata` type is correct as this is FAB related. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
