villebro commented on a change in pull request #9416: [mypy] Enforcing typing
for some modules
URL:
https://github.com/apache/incubator-superset/pull/9416#discussion_r403491574
##########
File path: superset/dao/base.py
##########
@@ -112,7 +112,7 @@ def update(cls, model: Model, properties: Dict, commit:
bool = True) -> Model:
return model
@classmethod
- def delete(cls, model: Model, commit=True):
+ def delete(cls, model: Model, commit: bool = True) -> Model:
Review comment:
I raised this in #9418 , I think that PR will benefit from this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
