villebro commented on a change in pull request #9366: deprecate groupby
controls in query_obj
URL:
https://github.com/apache/incubator-superset/pull/9366#discussion_r400321707
##########
File path: tests/viz_tests.py
##########
@@ -948,18 +942,6 @@ def test_query_obj_throws_metrics_and_groupby(self,
super_query_obj):
class BaseDeckGLVizTestCase(SupersetTestCase):
- def test_get_metrics(self):
- form_data = load_fixture("deck_path_form_data.json")
- datasource = self.get_datasource_mock()
- test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
- result = test_viz_deckgl.get_metrics()
- assert result == [form_data.get("size")]
-
- form_data = {}
- test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
- result = test_viz_deckgl.get_metrics()
- assert result == []
-
Review comment:
The `get_metrics()` method is no longer needed, hence this test is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
