john-bodley commented on issue #9366: deprecate groupby controls in query_obj URL: https://github.com/apache/incubator-superset/pull/9366#issuecomment-607603040 @villebro by only comment/thought regarding this and https://github.com/apache/incubator-superset/pull/9427 is whether it makes sense to have this behind a feature flag whilst you continue to work on the refactoring the viz plugins? If you feel confident with the changes I'm ok stamping the PRs, otherwise a feature flag may be beneficial for stability if it doesn't add too much complexity.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
