john-bodley commented on a change in pull request #9444: Implement dttm column
configuration through db extra config
URL:
https://github.com/apache/incubator-superset/pull/9444#discussion_r402062452
##########
File path: superset/connectors/sqla/models.py
##########
@@ -145,6 +146,17 @@ class TableColumn(Model, BaseColumn):
update_from_object_fields = [s for s in export_fields if s not in
("table_id",)]
export_parent = "table"
+ def get_expression(self):
+ if config["SIP_15_ENABLED"] and not self.expression:
+ db_default_expression = (
Review comment:
Why not just `return ( ...`. This results in one less variable, etc. and
thus make the code easier to grok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
