john-bodley commented on a change in pull request #9444: Implement dttm column
configuration through db extra config
URL:
https://github.com/apache/incubator-superset/pull/9444#discussion_r402066069
##########
File path: docs/installation.rst
##########
@@ -1379,8 +1379,14 @@ Prior to SIP-15 SQLAlchemy used inclusive endpoints
however these may behave lik
To remedy this rather than having to define the date/time format for every
non-IS0 8601 date-time column, once can define a default column mapping on a
per database level via the ``extra`` parameter ::
{
+ "main_dttm_column": "ds",
Review comment:
I sense these default settings (including the
`python_date_format_by_column_name` should be documented outside of the SIP-15
section (this section can then reference said section). This would help to
provide context regarding default database specific fields which may be
inherited either by new Superset tables going forward or used as a fallback (in
the case of SIP-15) if a value isn't defined.
Additionally I was wondering if having all these nested under a `defaults`
section ensures more consistency (and thus no need for the `default_` prefix),
```json
{
"defaults": {
"main_dttm_col": "ds",
"expression_by_column_name": {
"hour_ts": "CAST(hour_ts as INTEGER)"
},
"dttm_column_names": ["ds", "hour_ts"],
"python_date_format_by_column_name": {
"ds": "%Y-%m-%d",
"hour_ts": "epoch_s"
}
}
}
```
would be better documented in their own section, i.e., outside of SIP-15. It
could then be clearer to the reader that these database level overrides. If we
go down this route the `UPDATING.md` would need to be updated to reflect the
breaking SIP-15 config change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
