[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Thu, 02 Apr 2020 16:00:41 -0700 

gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify 
superset permissions
URL: 
https://github.com/apache/incubator-superset/pull/9458#discussion_r402644192
 
 

 ##########
 File path: superset/views/chart/views.py
 ##########
 @@ -33,6 +33,7 @@ class SliceModelView(
     SliceMixin, SupersetModelView, DeleteMixin
 ):  # pylint: disable=too-many-ancestors
     route_base = "/chart"
+    class_permission_name = "Chart"
 
 Review comment:
   This comes out okay, but the previous permission still persists.
   ![Screenshot from 2020-04-03 
04-29-21](https://user-images.githubusercontent.com/20752142/78307515-b52c1a80-7563-11ea-9795-e552d575323c.png)
   ![Screenshot from 2020-04-03 
04-29-49](https://user-images.githubusercontent.com/20752142/78307550-c8d78100-7563-11ea-9610-8663e784f8c4.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to