gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify
superset permissions
URL:
https://github.com/apache/incubator-superset/pull/9458#discussion_r403758396
##########
File path: superset/security/manager.py
##########
@@ -95,7 +95,7 @@ def __init__(self, **kwargs):
class SupersetSecurityManager(SecurityManager):
userstatschartview = None
- READ_ONLY_MODEL_VIEWS = {"DatabaseAsync", "DatabaseView",
"DruidClusterModelView"}
Review comment:
I think, these sets are meant to have the name of a View, it might be more
cleaner if we let views there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]