kristw commented on a change in pull request #9525: Migrating shared NVD3
controls to new module
URL:
https://github.com/apache/incubator-superset/pull/9525#discussion_r409264473
##########
File path: superset-frontend/src/explore/controlPanels/Bar.js
##########
@@ -29,39 +49,33 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
- ['show_brush', 'show_legend', 'show_bar_value'],
- ['rich_tooltip', 'bar_stacked'],
- ['line_interpolation', 'show_controls'],
- ['bottom_margin'],
+ [showBrush, showLegend, showBarValue],
+ [richTooltip, barStacked],
+ [lineInterpolation, showControls],
+ [bottomMargin],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', 'reduce_x_ticks'],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
This one also did not apply override to `xAxisFormat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
