rusackas commented on a change in pull request #9525: Migrating shared NVD3
controls to new module
URL:
https://github.com/apache/incubator-superset/pull/9525#discussion_r409267848
##########
File path: superset-frontend/src/explore/controlPanels/Area.js
##########
@@ -48,34 +62,30 @@ export default {
},
],
['color_scheme', 'label_colors'],
- ['rich_tooltip', 'show_controls'],
+ [richTooltip, showControls],
],
},
{
label: t('X Axis'),
expanded: true,
controlSetRows: [
- ['x_axis_label', 'bottom_margin'],
- ['x_ticks_layout', 'x_axis_format'],
- ['x_axis_showminmax', null],
+ [xAxisLabel, bottomMargin],
+ [xTicksLayout, xAxisFormat],
Review comment:
Effectively, yes. The majority of the `xAxisFormat` controls had the exact
same overrides, so I made _that_ the default configuration whem moving it to
`Shared_NVD3.js`, and instead added overrides the _other_ way. I figured the
majority use case should be the default :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
