[GitHub] [incubator-superset] etr2460 opened a new pull request #9587: [SQL Lab] Lock result set controls to be always visible

[GitBox]

etr2460 opened a new pull request #9587:
URL: https://github.com/apache/incubator-superset/pull/9587


   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Currently, it's possible to scroll the result set controls off screen when 
you have a very wide result set. This change fixes them to the top of the 
result set pane so they're always visible and useable
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   <img width="1600" alt="Screen Shot 2020-04-19 at 4 35 15 PM" 
src="https://user-images.githubusercontent.com/7409244/79702959-65389d80-825d-11ea-96b6-c42db4e8d431.png";>
   
   After:
   <img width="1609" alt="Screen Shot 2020-04-19 at 4 42 27 PM" 
src="https://user-images.githubusercontent.com/7409244/79702964-6a95e800-825d-11ea-8674-89e4746f26ba.png";>
   
   ### TEST PLAN
   Scroll horizontally in the result pane, see the buttons stick around
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @graceguo-supercat @rusackas @nytai 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org