ktmud commented on issue #9593: URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617418414
> `it doesn't throw errors` is not good enough. Dashboard will _persist_ some information in its metadata, default_filters, layout, filter scopes., etc into **dashboards** table. For example, a chart was a filter with filter but then it became non-filter chart...then how about those persisted metadata? For the long term it will cause data quality issue and many potential bugs. I mean, it's the same as removing a FilterBox from the dashboard. Do we do anything special right now for filter boxes when they are removed from the dashboard? My point is, there is no need for special treatment. If we think outdated metadata would be an issue, then it must be an issue for FilterBox, too. `It doesn't throw errors` was referring to the case you described---when a filter chart is removed from dashboard but the dashboard still persists metadata related to it. IMO, as long as the initialization process can safely ignore the outdated metadata when it realizes the related slice ID is not a filter chart, it's OK to leave the small pieces of metadata in persistent storage, just in case users want to change the same slice to a filter chart again. I'm OK with NOT merging this fix if we think there are too much trouble or a better solution down the line. @mistercrunch , question for you and @bolkedebruin , > Under which use cases [a filter table] is irreplaceable by a FilterBox? It seems there is a significant risk to future maintenance if we reintroduce this feature. Kind of feel we should deprecate it for now until we have a better idea on how to make this more robust. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
