graceguo-supercat commented on issue #9593: URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617449175
- when remove a filter_box from dashboard: Currently dashboard will detect this change in dashboardFilters reducer, and then it update filter scopes, default filters, etc. when user save dashboard changes, all metadata is updated. - when you use table filter in dashboard_1: 1. dashboard_1 owner set default filters and filter scopes for table filter 2. after some time, the table filter can be updated by owner or someone else, turn off its filter attribute, so it is a regular table, not a filter. 3. dashboard_1 still use this table as filter, right? because when dashboard loads filters related metadata, for example, default_filters, this slice's id is a filter key. My suggestion is enable table (or chart) as filter, but its state should be persist into dashboard metadata. You can still add chart's filter into dashboardFilters state, so that at this dashboard visit, these chart filters can work as filter. The difference from filter_box filter: - these chart filters have global scope, (if you want to use chart filter with respect to some tabs/charts, make a filter_box) - when save dashboard, chart filters' state should not be saved into metadata. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
