ktmud commented on issue #9593: URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617457694
If `table_filter` is turned off later, the chart will not be used as a filter, even if there is some lingering information about it in dashboard metadata. The initialization process should be able to just ignore that. (If it doesn't, then it needs a fix. I can add test cases to make sure it does.) The user interactions makes sense. I agree some users may find it simpler if all table filters are global. Maybe I missed something, but implementation wise, this could actually make things more complicated. We'd need to check chart types when saving dashboard metadata, which doesn't seem easy to pass around for `dashboardFilters`. Given that all charts will have a global scope by default, I wonder how much benefits it adds to make such a distinction. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
