dpgaspar edited a comment on pull request #9752:
URL:
https://github.com/apache/incubator-superset/pull/9752#issuecomment-624790056
thks for the ideas @mistercrunch, we had/have a couple of problems with
MSSQL on SQLLab.
1 - TOP wrapping was not working properly
2 - Even without TOP wrapping, functions on MSSQL like `COUNT`, `SUM` etc
are set has `<anonymous>` and these are not supported by superset (pandas
dataframes?)
Given that, maybe 2 is a good approach, or a mix of 1 and 2. May be wrong
here, but still think that altering SQL statements is dangerous/difficult and
kind of out of scope for superset. Another option could be: not forcing `TOP`
on some engines but refusing to execute statements that don't have them?
Note: This is scoped to MSSQL, because it was an obvious risky change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
