dpgaspar edited a comment on pull request #9752: URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-625398453
@bkyryliuk we have a simple query construction here: https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs/base.py#L397 and it's being used for MSSQL. Is this something similar with what you're looking for? @mistercrunch also mentioned that using a `WRAP_SQL` is inefficient on some engines. My plan is, if feasible/simple change `WRAP_SQL` to something like `FORCE_TOP` and doing the best to identify non aliased functions and warn the user about them. This last one could be tricky for statements like: `SELECT COL1, COL1, CAST(COL3 AS DATETIME) AT TIME ZONE "SOME_TZ", COL4` because `sqlparse` seems to get lost on `AT` and does not identify `COL4` has a column. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
