etr2460 opened a new pull request #9764: URL: https://github.com/apache/incubator-superset/pull/9764
### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Thanks to @villebro for helping start this PR. There's still one issue where when replacing, the table gets dropped but the new one isn't created. I think i might be doing something wrong with `engine.execute`, any thoughts? ### TEST PLAN - upload to a non existent table successfully with fail or replace selected - upload with append selected and see correct error message - upload to an existing table with fail selected and see correct error message - upload to an existing table with replace selected and see the table be replaced: NOT YET WORKING ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #9617 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @villebro @john-bodley @serenajiang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
