willbarrett commented on a change in pull request #9764:
URL:
https://github.com/apache/incubator-superset/pull/9764#discussion_r427595436
##########
File path: superset/db_engine_specs/hive.py
##########
@@ -179,11 +193,15 @@ def convert_to_hive_type(col_type: str) -> str:
bucket_path,
os.path.join(upload_prefix, table_name,
os.path.basename(filename)),
)
+ engine = cls.get_engine(database)
+
+ if if_exists == "replace":
+ engine.execute(f"DROP TABLE IF EXISTS {full_table_name}")
Review comment:
Yeah, this is scary. Let's see if we can explore some of the possible
solutions for this to get around adding another instance of SQL injection
vulnerability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
