etr2460 commented on a change in pull request #9820:
URL:
https://github.com/apache/incubator-superset/pull/9820#discussion_r426218098
##########
File path: superset-frontend/src/dashboard/util/getDashboardFilterKey.ts
##########
@@ -16,11 +16,20 @@
* specific language governing permissions and limitations
* under the License.
*/
-export function getDashboardFilterKey({ chartId, column }) {
+
+export interface GetDashboardFilterKeyProps {
Review comment:
no need to export this since it's only being used in this file
##########
File path: superset-frontend/src/dashboard/util/getRevertedFilterScope.ts
##########
@@ -18,20 +18,33 @@
*/
import { getChartIdAndColumnFromFilterKey } from './getDashboardFilterKey';
+export interface FilterScopeMap {
Review comment:
you don't need to export this (or the other interfaces, I'm going to
stop notating each one)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
