graceguo-supercat commented on a change in pull request #9820:
URL:
https://github.com/apache/incubator-superset/pull/9820#discussion_r427600283
##########
File path: superset-frontend/src/dashboard/util/getDashboardFilterKey.ts
##########
@@ -16,11 +16,20 @@
* specific language governing permissions and limitations
* under the License.
*/
-export function getDashboardFilterKey({ chartId, column }) {
+
+interface GetDashboardFilterKeyProps {
+ chartId: string;
+ column: number;
Review comment:
`column` should be string, mostly is column name to be filtered on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
