john-bodley commented on a change in pull request #9824:
URL:
https://github.com/apache/incubator-superset/pull/9824#discussion_r426869164
##########
File path: superset/connectors/druid/models.py
##########
@@ -1240,7 +1268,7 @@ def run_query( # druid
qry["limit"] = row_limit
client.scan(**qry)
elif (IS_SIP_38 and columns) or (
- not IS_SIP_38 and len(groupby) == 0 and not having_filters
+ not IS_SIP_38 and (not groupby or len(groupby) == 0) and not
having_filters
Review comment:
@villebro thanks. I agree and made this change elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
