john-bodley commented on a change in pull request #9824:
URL:
https://github.com/apache/incubator-superset/pull/9824#discussion_r426872156
##########
File path: superset/connectors/druid/models.py
##########
@@ -1322,13 +1347,13 @@ def run_query( # druid
set([x for x in pre_qry_dims if not isinstance(x, dict)])
)
dict_dims = [x for x in pre_qry_dims if isinstance(x, dict)]
- pre_qry["dimensions"] = non_dict_dims + dict_dims
+ pre_qry["dimensions"] = non_dict_dims + dict_dims # type:
ignore
- order_by = None
+ order_by = None # type: ignore
Review comment:
@villebro the issue here is that `order_by` has already been defined on
line 1291,
```python
order_by = utils.get_metric_name(timeseries_limit_metric)
```
I declared the type as `order_by: Optional[str] = None`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
