villebro commented on a change in pull request #9825:
URL:
https://github.com/apache/incubator-superset/pull/9825#discussion_r427019488
##########
File path: superset/config.py
##########
@@ -351,8 +351,9 @@ def _try_json_readsha(filepath, length): # pylint:
disable=unused-argument
SUPERSET_WEBSERVER_DOMAINS = None
# Allowed format types for upload on Database view
-# TODO: Add processing of other spreadsheet formats (xls, xlsx etc)
-ALLOWED_EXTENSIONS = {"csv", "tsv"}
+EXCEL_EXTENSION = ["xlsx", "xls"]
+CSV_EXTENSION = ["csv", "tsv"]
+ALLOWED_EXTENSIONS = {"csv", "tsv", "xlsx", "xls"}
Review comment:
```suggestion
EXCEL_EXTENSION = {"xlsx", "xls"}
CSV_EXTENSION = {"csv", "tsv"}
ALLOWED_EXTENSIONS = {*EXCEL_EXTENSION, *CSV_EXTENSION}
```
The first two should be sets, and the last one should be a union of the
above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
