villebro commented on pull request #9825:
URL: 
https://github.com/apache/incubator-superset/pull/9825#issuecomment-630732767


   @blcksrx at least the following files are involved in the CSV upload feature:
   - `superset/app.py`: here the menu item is defined.
   - `superset/views/database/forms.py`: here the actual form is defined.
   - `superset/views/database/views.py`: here the view is defined.
   
   I think Uploading of Excel files probably needs to happen via a dedicated 
dialog, as many of the CSV fields are not applicable for Excel. Having said 
that, many are, hence it might make sense to have a parent form with the global 
options (fail, replace, append etc), and then only add/override the ones that 
are specific to the format in question.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to