john-bodley commented on a change in pull request #9912:
URL:
https://github.com/apache/incubator-superset/pull/9912#discussion_r430867023
##########
File path: superset/views/chart/filters.py
##########
@@ -14,14 +14,17 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from typing import Callable
+
from sqlalchemy import or_
+from sqlalchemy.orm.query import Query
from superset import security_manager
from superset.views.base import BaseFilter
class SliceFilter(BaseFilter): # pylint: disable=too-few-public-methods
- def apply(self, query, value):
+ def apply(self, query: Query, value: str) -> Query:
Review comment:
Note this comment outdated and now is typed as `value: Optional[Any]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
