john-bodley commented on a change in pull request #9912:
URL:
https://github.com/apache/incubator-superset/pull/9912#discussion_r431289300
##########
File path: superset/connectors/sqla/models.py
##########
@@ -90,6 +90,7 @@ class AnnotationDatasource(BaseDatasource):
cache_timeout = 0
changed_on = None
+ type = "annotation"
Review comment:
@villebro I needed to add this to after making the `BaseDatasource.type`
an abstract property otherwise
[this](https://github.com/apache/incubator-superset/blob/master/superset/connectors/base/models.py#L111)
would barf. Note even though unused I gather having `<id>__annotation` is more
accurate that `<id>__None` which it was previously.
cc: @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
