mistercrunch commented on a change in pull request #9810:
URL:
https://github.com/apache/incubator-superset/pull/9810#discussion_r434321987
##########
File path: superset/tasks/schedules.py
##########
@@ -33,24 +33,25 @@
from flask import render_template, Response, session, url_for
from flask_babel import gettext as __
from flask_login import login_user
-from retry.api import retry_call
+from retry.api import retry, retry_call
Review comment:
`schedules.py` is getting pretty big, would it make sense to have
a`utils/slack.py`?
##########
File path: requirements.txt
##########
@@ -4,92 +4,87 @@
#
# pip-compile --output-file=requirements.txt setup.py
#
-alembic==1.4.2 # via flask-migrate
+alembic==1.3.2 # via flask-migrate
Review comment:
Looks like there's a bad rebase here, lots of downgrades...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]