willbarrett opened a new pull request #10078: URL: https://github.com/apache/incubator-superset/pull/10078
### SUMMARY The file `superset/views/core.py` is massive, to the point that I get lost in there all the time when I'm working on something. There's no need for us to stuff so much functionality into a single Python module. This PR tackles some low-hanging fruit for breaking up this file, moving out a few pieces that are logically separate from the elephant in the room: the `Superset` class. I'm hoping that in a near-future PR I'll be able to start breaking up some of the larger functions in the `Superset` class, but I wanted to get the community's reaction to these changes first. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TEST PLAN <!--- What steps should be taken to verify the changes --> CI! Boot up locally and make sure everything still works! ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### Reviewers @john-bodley @mistercrunch @craig-rueda ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
