willbarrett commented on pull request #10078: URL: https://github.com/apache/incubator-superset/pull/10078#issuecomment-645753733
@john-bodley agreed on centralizing base classes. As for `core.py`, I think `core.py` should turn into `superset.py` and only hold the `Superset` class. Ideally the majority of the functionality of that class would be extracted to Command or DAO objects. More on this in PR form in the near future I hope. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
