ktmud edited a comment on pull request #10056:
URL: 
https://github.com/apache/incubator-superset/pull/10056#issuecomment-645565878


   There are still a couple of places that have the light blue in light 
background, most noticeably the btn-default and text links. I think SIP-34 
design mostly used what it calls 
"[SECONDARY](https://projects.invisionapp.com/share/V5VH03AHBER#/screens/399817735)"
 buttons in replacement of the `btn-default` from Bootstrap.
   
   I [updated the CSS a 
little](https://github.com/apache/incubator-superset/compare/cartel...ktmud:cartel)
 so hopefully it made things a little bit better:
   
   
![Snip20200617_36](https://user-images.githubusercontent.com/335541/84933129-43576d80-b08a-11ea-9df1-e9b264705c91.png)
   
   
![image](https://user-images.githubusercontent.com/335541/84934085-b44b5500-b08b-11ea-9e18-9f3027af6213.png)
   
   
![image](https://user-images.githubusercontent.com/335541/84938758-60903a00-b092-11ea-80d2-26bfcb744afd.png)
   
   Would be nice if there're design mockups for the intermediate state between 
current Superset and SIP-34 so we could have a better idea how to replace 
different elements with a11y in mind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to