mistercrunch commented on pull request #10056: URL: https://github.com/apache/incubator-superset/pull/10056#issuecomment-645653745
@ktmud thanks for the feedback, yeah the reason I used what SIP-34 calls "button tertiary" instead of "button secondary" is because we currently use a lot of `btn-group`, and the borderless "button secondary" didn't look super good (but may be ok, idk). I thought I'd use tertiary for now until we break down the buttons into less buttons and hamburgers `btn-dropdown`... Happy to go either way. Clearly this is just the first of many PRs in that general SIP-34 theme direction. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
