rusackas opened a new pull request #10105: URL: https://github.com/apache/incubator-superset/pull/10105
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Initial report: > "Filter widgets don't show a ""loading"" spinner, so there is no indication of when the (valid) filter values are loaded. This is a problem with dynamic filters where the underlying logic that returns the filter values can change, or where they depend on settings for other values. The only way to see when it's been updated is by examining the drop-down values to see when they've changed (or if you know what to expect, when the correct values are shown). Issue uncovered: The loader was indeed there, but buried (z-index-wise) below the controls. The fix: Could this be fixed with one line of CSS? Yep! But that's not the _right_ way. This PR does the following: 1. Reverses the rendering order of the three key layers in `chart.jsx` so the Loader is atop the Refresh overlay atop the Chart itself. Not sure why it would be the other way, but if anyone has some idea, let me know! 2. Touches up a bunch of CSS to make the positioning of those re-stacked elements work 3. Moves the CSS out of LESS and into Emotion 👩🎤 4. Migrates `Loading` and `RefreshChartOverlay` components to tsx. 5. Removes the `size` prop from Loading, which sure seems to be unused 6. Removes some unused css for a "dismiss" button that no longer seems to exist. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
