rusackas commented on a change in pull request #10105:
URL:
https://github.com/apache/incubator-superset/pull/10105#discussion_r443730144
##########
File path: superset-frontend/src/components/Loading.tsx
##########
@@ -41,21 +33,26 @@ const FLOATING_STYLE = {
transform: 'translate(-50%, -50%)',
};
-export default function Loading({ size, position, className }) {
+const LoaderImg = styled.img`
+ z-index: 1000;
+ &.margin-zero {
+ margin: 0px;
+ }
+`;
+export default function Loading({
+ position = 'floating',
+ className = '',
+}: Props) {
const style = position === 'floating' ? FLOATING_STYLE : {};
const styleWithWidth = {
Review comment:
Fixed... thanks for the eagle-eyes. I actually see a couple more funny
things that look like they can be simplified here, so I'll nab those too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
