dpgaspar commented on a change in pull request #10106:
URL:
https://github.com/apache/incubator-superset/pull/10106#discussion_r442826337
##########
File path: superset/connectors/sqla/models.py
##########
@@ -461,7 +460,7 @@ def make_sqla_column_compatible(
if db_engine_spec.allows_column_aliases:
label = db_engine_spec.make_label_compatible(label_expected)
sqla_col = sqla_col.label(label)
- sqla_col._df_label_expected = label_expected
+ sqla_col._df_label_expected = label_expected # pylint:
disable=protected-access
Review comment:
Should we make it public or accessible through a property?
##########
File path: superset/connectors/sqla/views.py
##########
@@ -377,10 +384,14 @@ class TableModelView(DatasourceModelView, DeleteMixin,
YamlExportMixin):
)
}
- def pre_add(self, table: "TableModelView") -> None:
+ def pre_add( # pylint: disable=arguments-differ
Review comment:
`pre_add(self, item: "TableModelView"): -> None` will this satisfy
pylint?
##########
File path: superset/result_set.py
##########
@@ -48,14 +47,14 @@ def dedup(l: List[str], suffix: str = "__", case_sensitive:
bool = True) -> List
"""
new_l: List[str] = []
seen: Dict[str, int] = {}
- for s in l:
- s_fixed_case = s if case_sensitive else s.lower()
+ for string in l:
Review comment:
nit: We already know it's a string, I propose calling `item` instead of
`string`
##########
File path: superset/security/manager.py
##########
@@ -273,7 +276,9 @@ def can_access_datasource(self, datasource:
"BaseDatasource") -> bool:
"datasource_access", datasource.perm or ""
)
- def get_datasource_access_error_msg(self, datasource: "BaseDatasource") ->
str:
+ def get_datasource_access_error_msg( # pylint: disable=no-self-use
Review comment:
```
@staticmethod
def get_datasource_access_error_msg(
self, datasource: "BaseDatasource"
) -> str:
...
```
##########
File path: superset/security/manager.py
##########
@@ -284,7 +289,9 @@ def get_datasource_access_error_msg(self, datasource:
"BaseDatasource") -> str:
return f"""This endpoint requires the datasource {datasource.name},
database or
`all_datasource_access` permission"""
- def get_datasource_access_link(self, datasource: "BaseDatasource") ->
Optional[str]:
+ def get_datasource_access_link( # pylint:
disable=unused-argument,no-self-use
Review comment:
`@staticmethod`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
