willbarrett commented on a change in pull request #10106:
URL:
https://github.com/apache/incubator-superset/pull/10106#discussion_r443050966
##########
File path: superset/connectors/sqla/models.py
##########
@@ -461,7 +460,7 @@ def make_sqla_column_compatible(
if db_engine_spec.allows_column_aliases:
label = db_engine_spec.make_label_compatible(label_expected)
sqla_col = sqla_col.label(label)
- sqla_col._df_label_expected = label_expected
+ sqla_col._df_label_expected = label_expected # pylint:
disable=protected-access
Review comment:
Unfortunately the type on this is `Column`, which comes direct from
SQLAlchemy. I'd prefer not to monkeypatch their internals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
