john-bodley commented on a change in pull request #10197:
URL:
https://github.com/apache/incubator-superset/pull/10197#discussion_r448112137
##########
File path: superset/utils/log.py
##########
@@ -36,31 +36,32 @@ def log(
pass
def log_this(self, f: Callable[..., Any]) -> Callable[..., Any]:
+ from superset.views.core import get_form_data
Review comment:
@bkyryliuk I've added a unit test per your suggestion. Note rather than
mocking the `log_this` wrapped function and callback opted to call the
`explore_json` endpoint and verified the logged database record.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
