bkyryliuk commented on a change in pull request #10197:
URL: 
https://github.com/apache/incubator-superset/pull/10197#discussion_r449190159



##########
File path: tests/utils_tests.py
##########
@@ -1316,3 +1316,30 @@ def test_get_form_data_globals(self) -> None:
             )
 
             self.assertEqual(slc, None)
+
+    def test_log_this(self) -> None:

Review comment:
       add a todo to add other test cases that cover log_this logic, could be 
fun onboarding task for someone :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to