mistercrunch commented on a change in pull request #10084:
URL:
https://github.com/apache/incubator-superset/pull/10084#discussion_r448609942
##########
File path: tests/db_engine_specs/hive_tests.py
##########
@@ -16,6 +16,10 @@
# under the License.
from unittest import mock
+from pyhive import hive
+from sqlalchemy import column
+from sqlalchemy.dialects import *
Review comment:
+1, let's not `import *` as we can't trace where objects are coming
from, otherwise LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
