villebro commented on a change in pull request #10084:
URL:
https://github.com/apache/incubator-superset/pull/10084#discussion_r450627712
##########
File path: tests/db_engine_specs/hive_tests.py
##########
@@ -233,4 +233,4 @@ def test_get_create_table_stmt() -> None:
STORED AS TEXTFILE LOCATION :location
tblproperties
('skip.header.line.count'=':header_line_count')""",
{"delim": ",", "location": "s3a://directory/table",
"header_line_count": "101"},
- )
+ )
Review comment:
line change missing here
##########
File path: requirements-dev.txt
##########
@@ -31,6 +31,7 @@ pycodestyle==2.5.0
pydruid==0.6.1
pyhive==0.6.2
pylint==2.5.3
+ded thrift dependency
Review comment:
typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
