graceguo-supercat edited a comment on pull request #10275: URL: https://github.com/apache/incubator-superset/pull/10275#issuecomment-656422291
it seems i used a `close` class shipped with bootstrap? <img width="1306" alt="Screen Shot 2020-07-09 at 5 50 04 PM" src="https://user-images.githubusercontent.com/27990562/87104455-d52b4400-c20c-11ea-969d-3081ca18bca9.png";> I didn't know it's from bootstrap... just want to overwrite some default behavior :) all other places used `fa fa-close`. maybe i should change to that? and later when you do convert it's easier to find all uses? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/87104455-d52b4400-c20c-11ea-969d-3081ca18bca9.png"](https://user-images.githubusercontent.com/27990562/87104455-d52b4400-c20c-11ea-969d-3081ca18bca9.png"){kind=link}