mistercrunch commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r452650000
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -289,9 +289,10 @@ class TabbedSqlEditors extends React.PureComponent {
const title = (
<>
{qe.title} <TabStatusIcon tabState={state} />{' '}
- <span className="close" onClick={() => this.removeQueryEditor(qe)}>
- {'×'}
- </span>
+ <i
+ className="fa fa-close"
Review comment:
https://github.com/apache/incubator-superset/blob/master/superset-frontend/stylesheets/less/variables.less#L48-L56
not sure how to use these grays in this context, @rusackas ?
- create classes in `superset.less` and use them as classes
- create a `./TabbedSqlEditors.less` and use the variable in there?
- use emotion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
